Closed joshdarby closed 4 years ago
Should we name it something like City Limits Special Projects Series Archive? Sounds good to me.
I had to redeclare largo_load_more_posts_choose_partial since the filter largo_lmp_template_partial doesn't pass the $query_vars for me to be able to check if the widget is calling LMP. Is there an easier way to do this besides redeclaring this function?
Aren't they passed to the filter as $post_query->query_vars?
Make sure both widgets do not display duplicate posts
If both widgets have checked the box to avoid duplicate posts, then it works.
Er, yep. I read that wrong because
* When building your own filter, you must set the fourth parameter of add_filter to 2:
// *
// * function your_filter_name($partial, $post_type) {
post_type
got me mixed up. I'll update to use the filter instead of redeclaring the function.
Changes
This pull request makes the following changes:
City Limits Special Projects Featured Content
widget to display the rest of the posts on a series landing page, loosely based off of Largo Recent Posts widgetDesktop:
Mobile:
Why
For #73
Testing/Questions
Features that this PR affects:
Questions that need to be answered before merging:
City Limits Special Projects Featured Content
since that's what it's named in #73, but that feels like it's kind of misleading since this is really just posts that haven't been displayed already. Should we name it something likeCity Limits Special Projects Series Archive
?largo_load_more_posts_choose_partial
since the filterlargo_lmp_template_partial
doesn't pass the$query_vars
for me to be able to check if the widget is calling LMP. Is there an easier way to do this besides redeclaring this function?Steps to test this PR:
City Limits Seven Series Posts
widget to the landing page and set it to avoid duplicatesCity Limits Special Projects Featured Content
widget to a landing page and make sure it's set to avoid duplicate posts