Client qa updates

[joshdarby]

Changes

This pull request makes the following changes:

• Allows users to deselect a secondary nav on series landing pages https://github.com/INN/umbrella-citylimits/commit/e1faebd737934af6530b4ab3b50f2d0b9c3fc3e2
• Updates the way footer widgets are found on the special projects template, based on https://github.com/INN/largo/issues/1839 https://github.com/INN/umbrella-citylimits/commit/e2443a8a457b584a7dbd16a08e3fbb09011cedc3
• Decreases the font size of the top featured homepage story to match the secondary featured stories https://github.com/INN/umbrella-citylimits/commit/bcb435e10cb82c602e12b2c39a2647c8ec476e10
• Swaps largo_series_before_stories to city_limits_special_projects_series_before_stories on the special stories series template so that the hardcoded newsletter that was being called on the largo_series_before_stories action does not appear. Also hides the #before-footer .newsletter-signup element. https://github.com/INN/umbrella-citylimits/commit/c1b54635de3af2aa49aa0c5d29995c7505aa3799
• Adds new mobile-sticky-main-menu menu location so that a different menu can be selected for the expanded open mobile menu. Also adds back in the main-nav menu location so users can toggle a different menu for that location. https://github.com/INN/umbrella-citylimits/commit/a40e39555040a683e851bdf538912a577d22eccd
• Hides the .footer.mobile.newsletter-signup popup on all mobile pages, not just the homepage https://github.com/INN/umbrella-citylimits/pull/136/commits/217cc7a7aaf0e2ddd68c4a37e79de706b3d29154

Why

For #133

Testing/Questions

Features that this PR affects:

• Homepage top featured story
• Special projects series landing page footer widget area and newsletter signup form
• Special projects landing page secondary menu selector
• Menu locations for the main nav and expanded mobile main nav

Questions that need to be answered before merging:

• [x] Is this PR targeting the correct branch in this repository?
• [ ] Is there a better way to allow users to select an empty value for the landing page secondary nav dropdown and save it other than just allowing || '0' === $_POST[$field_name]?

Steps to test this PR:

Homepage top featured story:

1. View the mobile homepage and verify the top story title has the same font size and secondary featured story titles

Special projects series landing page footer widgets

1. Create/modify a landing page that has a name different from the selected series
2. Make sure it has the "Widget" footer option selected
3. Add widgets to that widget area and verify they appear on the frontend

Allow selection of empty secondary nav on landing pages

1. Create/modify a landing page and select a secondary nav menu, then save
2. Set the secondary nav menu back to - Select - option and save
3. Verify no secondary menu appears on the frontend

Remove hardcoded newsletter signup from new series template

1. View a landing page using the special projects series template and verify no newsletter signups are present
2. Add the newsletter signup widget to the above landing page and verify it works and looks ok

Allow selection of different menu for open toggled mobile nav

1. Go to menus in the admin panel
2. Add a menu to the Main Navigation menu location
3. Add a menu to the Mobile Sticky Main Nav menu location
4. Verify the main desktop nav is correct and the expanded mobile nav is correct and match their selected menus on their respective menu locations

[benlk]

Instead of hiding the mobile popup on all pages, is there any reason we shouldn't remove it outright?

https://github.com/INN/umbrella-citylimits/blob/775d526602313da246e5d24b39a1e9d0966e5de7/wp-content/themes/citylimits/functions.php#L337-L340

[joshdarby]

Instead of hiding the mobile popup on all pages, is there any reason we shouldn't remove it outright?

@benlk I'm probably wrong here, but wouldn't that remove it from desktop too? I know they only want it removed from mobile currently.

[benlk]

With CSS, we're hiding .footer.mobile, and the only HTML/PHP I can find that has that combination of classes is /partials/newsletter-signup-popover.php, where the element with .footer.mobile contains everything within that partial. The other newsletter-signup- partials have other combinations of classes.

Everything else is :shipit:

[joshdarby]

With CSS, we're hiding .footer.mobile, and the only HTML/PHP I can find that has that combination of classes is /partials/newsletter-signup-popover.php, where the element with .footer.mobile contains everything within that partial. The other newsletter-signup- partials have other combinations of classes.

Alright, you've convinced me!

[joshdarby]

@benlk Removed in https://github.com/INN/umbrella-citylimits/pull/136/commits/cb646ab649d18a0c9938756944be0847fe65c2c2