High priority updates - Githubissues

INN / umbrella-citylimits

CityLimits.org Site

https://citylimits.org

GNU General Public License v2.0

0 stars 2 forks source link

High priority updates #140

Closed joshdarby closed 4 years ago

joshdarby commented 4 years ago

Changes

This pull request makes the following changes:

Removes the gray overlay from homepage special projects section
Removes excerpt from homepage secondary featured stories
Updates header ad zone css to set iframe to max-width:100% and make sure parent container is still 100vw on mobile

Why

For #139

Testing/Questions

Features that this PR affects:

Header ad
Homepage featured stories
Homepage special projects section

Questions that need to be answered before merging:

[ ] Is this PR targeting the correct branch in this repository?

joshdarby commented 4 years ago

Note that this fixes the actual spacing overflow for the header ad, but the ad is still cut off because the image is wider than the parent container. I believe this is something to fix on the Google end because we can't modify CSS for content of the iframe where the ad is being served.

Screen Shot 2019-12-23 at 4 18 46 PM