INN / umbrella-citylimits

CityLimits.org Site
https://citylimits.org
GNU General Public License v2.0
0 stars 2 forks source link

Additional site tweaks #142

Closed joshdarby closed 4 years ago

joshdarby commented 4 years ago

Changes

This pull request makes the following changes:

Why

For #141

Testing/Questions

Features that this PR affects:

Questions that need to be answered before merging:

Steps to test this PR:

Newsletter on archives and old series template:

  1. Go to an archive page, such as an author page, and verify the hardcoded version of the newsletter isn't present
  2. Do #1 again but on a series landing page using the old template

Sidebar newsletter signup placeholders

  1. View the sidebar newsletter widget on a narrow-ish screen size and verify you can still read the input placeholders

Header buttons being squished

  1. View the header on a narrow screen size and verify the buttons don't crash into each other anymore

Homepage special projects title/image

  1. View the homepage special projects widget and verify no image overlay is present
  2. Make sure the title and image link still work as expected
benlk commented 4 years ago

There's not a great way to make sure all of the title heights are the same now that they are moved below the image, resulting in the lists of series posts looking uneven if a title has 2 lines vs 1.

CSS Grid might work here, but it would require a lot of micromanaging of position of elements and probably more than a bit of display: contents;.

joshdarby commented 4 years ago

CSS Grid might work here, but it would require a lot of micromanaging of position of elements and probably more than a bit of display: contents;

That's what I figured. 😕