INN / umbrella-citylimits

CityLimits.org Site
https://citylimits.org
GNU General Public License v2.0
0 stars 2 forks source link

Update template for Neighborhoods pages to remove MTF top logo #147

Open MirandaEcho opened 4 years ago

benlk commented 4 years ago

Example: https://citylimits.org/neighborhoods/east-harlem/

Present:

Screen Shot 2020-02-04 at 18 05 50

To remove the image:

https://github.com/INN/umbrella-citylimits/blob/1287456c1b8474a782cfb020fcf32030d05b0d26/wp-content/themes/citylimits/header-rezone.php#L158

Removing the image from header-rezone.php will affect:

Should this change only affect the Neighborhoods pages, or all pages currently using this header?

After removing the image:

Screen Shot 2020-02-04 at 18 06 24

Are there any other changes that need to be made to this area?

MirandaEcho commented 4 years ago

@benlk - its an old logo, so lets remove it from anywhere its used in the header

MirandaEcho commented 4 years ago

What would it take to add the top portion (name, photo, blurb, icon) from this page: https://citylimits.org/series/futuremap/ to the Neighborhoods template as well?

joshdarby commented 4 years ago

What would it take to add the top portion (name, photo, blurb, icon) from this page: https://citylimits.org/series/futuremap/ to the Neighborhoods template as well?

@MirandaEcho Do you want an estimate for that or do you want me to try and cram it in to the remaining 57m this issue has?

joshdarby commented 4 years ago

Update: tried adding the section to the old template while using the existing CSS. Most of it worked, but we'd need to modify some parts. I'd think we could get this done in under an hour and a half (including review).

joshdarby commented 4 years ago

Another update:

The only modification I had to make was moving #series-header and .series-banner out of the parent .cftl-tax-landing-template-series-landing-special-projects-php styling

screencapture-citylimits-test-series-futuremap-2020-02-19-15_31_34-1

The only issue I can see is that from 800px to 600px, the header area overlaps the rezone-overview area

Screen Shot 2020-02-19 at 3 34 00 PM

MirandaEcho commented 4 years ago

@joshdarby - is this done then and on staging?

joshdarby commented 4 years ago

@MirandaEcho No, I was never told whether or not the estimate I gave was approved and that I could finish up the work on it

MirandaEcho commented 4 years ago

I wasn't sure if that last update meant it was done or not, sorry! Please proceed. Thanks!

joshdarby commented 4 years ago

@MirandaEcho This is now deployed to staging.

MirandaEcho commented 4 years ago

@joshdarby lets hardcode this as the featured image in the top (next to the page title) while keeping the neighborhood featured image below it:

Mapping the future