INN / umbrella-citylimits

CityLimits.org Site
https://citylimits.org
GNU General Public License v2.0
0 stars 2 forks source link

Add new series header to old series template header #161

Closed joshdarby closed 4 years ago

joshdarby commented 4 years ago

Changes

This pull request makes the following changes:

Main page: screencapture-citylimits-test-series-futuremap-2020-02-21-10_49_01

Interior page: screencapture-citylimits-test-neighborhoods-bay-street-2020-02-21-10_49_49

Mobile: screencapture-citylimits-test-series-futuremap-2020-02-21-10_49_24

Why

For #147

Testing/Questions

Features that this PR affects:

Questions that need to be answered before merging:

Steps to test this PR:

  1. View a series landing page using the old template
  2. View on frontend and make sure it looks ok
benlk commented 4 years ago
joshdarby commented 4 years ago

What can we do to improve the layout for series that do not have a featured image on the >landing page? Or is that a concern? Are we worried about the red underlines on the menu bits on mobile on /series/futuremap?

I think those are better answered by @MirandaEcho 😄

kaylima commented 4 years ago

@benlk how much time would it take to remove the red lines underneath and also remove the white to the left of "News" OR to add a white line to the left of "Get involved" so that it's consistent?

joshdarby commented 4 years ago

how much time would it take to remove the red lines underneath and also remove the white to the left of "News" OR to add a white line to the left of "Get involved" so that it's consistent?

@kaylima About 5 minutes for each issue + time for review

Screen Shot 2020-02-21 at 4 55 29 PM

joshdarby commented 4 years ago

Updated in https://github.com/INN/umbrella-citylimits/pull/161/commits/74afb8ab0d02d24038f0a5fded9aa6660f743763