INN / umbrella-citylimits

CityLimits.org Site
https://citylimits.org
GNU General Public License v2.0
0 stars 2 forks source link

Site header #81

Closed joshdarby closed 4 years ago

joshdarby commented 4 years ago

Changes

This pull request makes the following changes:

Desktop:

Screen Shot 2019-10-25 at 10 24 16 AM

Mobile:

Screen Shot 2019-10-25 at 10 24 29 AM

Why

For #39

Testing/Questions

Features that this PR affects:

Questions that need to be answered before merging:

Steps to test this PR:

  1. Add a search widget to the Header widget widget area
  2. Add a custom html widget to the Header widget widget area containing this html:
    <div class="header-button-container">
    <a href="#" class="btn btn-red">Newsletter</a>
    <a href="#" class="btn btn-black">Donate</a>
    </div>
joshdarby commented 4 years ago

Does this work on https://citylimits.test/series/futuremap/ ?

@benlk Good question. It apparently does not work, but I'm unsure of whether or not that's right or wrong on these pages since on the live CL sites they don't even have a main nav.

Edit: Nevermind, apparently it does have a main nav. Not sure why I thought it didn't. So I'm guessing that yes, we do want this to work there.

benlk commented 4 years ago

I'm unsure of whether or not that's right or wrong on these pages since on the live CL sites they don't even have a main nav.

It looks like https://citylimits.org/series/futuremap/ is a page that uses the sticky nav in place of the main nav.

at 5ebddf208cd4c70e82318aff7069352a0b58248a, the last chunk of work we did on this site, the sticky nav appears at the top of the page.

at 6ab9d85efeb1e2c9d8af2b4df03307073eb4b225 after merging the outside PR #33, the sticky nav is also present on the page.

joshdarby commented 4 years ago

@benlk https://github.com/INN/umbrella-citylimits/pull/81/commits/ecfa79e6c43b53874cb3b2d711957c5eef5fa3ab adds the new header to the header-zone.php template which is used on /series/futuremap