INN / umbrella-citylimits

CityLimits.org Site
https://citylimits.org
GNU General Public License v2.0
0 stars 2 forks source link

Add a Special Projects template, and format its header #88

Closed benlk closed 4 years ago

benlk commented 4 years ago

Changes

This pull request makes the following changes:

Screenshot_2019-11-04 Election Watch 2018 City Limits-mobile Screenshot_2019-11-04 Election Watch 2018 City Limits-tablet Screenshot_2019-11-04 Election Watch 2018 City Limits

Why

For #68 and to give us a template for testing special projects widgets as part of #71

Testing/Questions

Features that this PR affects:

Questions that need to be answered before merging:

Steps to test this PR:

  1. Create a new series landing page, or edit an existing one.
  2. Set the template to Series Landing Page - Special Projects: Screen Shot 2019-11-04 at 15 29 18
  3. Set the title and description.
  4. Set a featured image for the landing page.
  5. Save/Update.
  6. View the landing page.
joshdarby commented 4 years ago

@benlk Do you think we should increase the height and padding on the series-header element on larger screen sizes so it matches the mockup more closely?

Here's how it looks at 1920px Screen Shot 2019-11-05 at 12 04 01 PM

benlk commented 4 years ago

Part of the apparent-size problem is that the containing element is the minimum size of its content. Putting more words in the description will make the box bigger, up to 50% max-width.

Screen Shot 2019-11-05 at 21 14 57

benlk commented 4 years ago

Changes in https://github.com/INN/umbrella-citylimits/pull/88/commits/a94f095cf35c2344013be41dbb2adf14c9dd9d6a:

Screen Shot 2019-11-05 at 21 22 49 Screen Shot 2019-11-05 at 21 23 03 Screen Shot 2019-11-05 at 21 23 12 Screen Shot 2019-11-05 at 21 23 18

joshdarby commented 4 years ago

@benlk The changes in https://github.com/INN/umbrella-citylimits/commit/a94f095cf35c2344013be41dbb2adf14c9dd9d6a look good 👍

should this implement the fancy centered-with-borders styles for the "Special Project" tag?

I would think so, since that's how the mockup looks for the mobile version.

Screen Shot 2019-11-06 at 9 46 53 AM

benlk commented 4 years ago

Pseudoelement hax in https://github.com/INN/umbrella-citylimits/pull/88/commits/e26b24123853d30dc334170c993e4958838c1be2 gets us this without having to add a new border-image in img/: Screen Shot 2019-11-06 at 15 37 05 Screen Shot 2019-11-06 at 15 37 17 Screen Shot 2019-11-06 at 15 37 30