INN / umbrella-currentorg

umbrella repository for current.org
https://current.org
GNU General Public License v2.0
0 stars 1 forks source link

Mobile functionality for single views #142

Closed joshdarby closed 4 years ago

joshdarby commented 4 years ago

Changes

This pull request makes the following changes:

Why

For #125 / 141

Testing/Questions

Features that this PR affects:

Questions that need to be answered before merging:

Steps to test this PR:

  1. View a page with the projects shortcode and play around on desktop and mobile
joshdarby commented 4 years ago

Would it make sense to not change the position based on show/hide of the sticky nav, but instead position the element such that it's always visible, with and without the sticky nav?

@benlk How were you thinking of doing this?

benlk commented 4 years ago

I would:

joshdarby commented 4 years ago

@benlk If we do the above, doesn't it look kind of weird with all of the white space when the sticky nav is not visible?

Screen Shot 2020-06-04 at 10 12 45 AM

benlk commented 4 years ago

If the borders are such that the black outline stays at a fixed height from the top of the page, and from the bottom of the page, I think it's less weird/annoying than if the div keeps shifting when people change scroll direction.

It looks like https://jobs.current.org/jobseeker/search/results/ solves this problem by limiting the search results' height on the page, and then having both the list and the post scroll within that container.

benlk commented 4 years ago

@kaylima any thoughts?