INN / umbrella-currentorg

umbrella repository for current.org
https://current.org
GNU General Public License v2.0
0 stars 1 forks source link

Internal qa updates #144

Closed joshdarby closed 4 years ago

joshdarby commented 4 years ago

Changes

This pull request makes the following changes:

screencapture-currentorg-test-local-projects-2020-06-04-16_27_40

Why

For #142

Testing/Questions

Features that this PR affects:

Questions that need to be answered before merging:

Steps to test this PR:

  1. View the projects page and poke around. Make sure none of the new styles broke anything
joshdarby commented 4 years ago

@benlk https://github.com/INN/umbrella-currentorg/pull/144/commits/876090763b3b1737378e8eb3821da23c87d918f5 is my attempt at a good solution for resetting the query results so the default post is the first one from the query results. Let me know if you have a better solution in mind.

benlk commented 4 years ago

Screen Shot 2020-06-05 at 11 54 43

The only remaining thing that seems strange to me is the mismatch between display presentations of project terms. If we're having solid-color backgrounds, we need some padding.

Should the single-item view adopt the bordered button styles from the list view?

The rest of this is good to go.

joshdarby commented 4 years ago

Should the single-item view adopt the bordered button styles from the list view?

@benlk, Kay mentioned yesterday that she does not want the "button" styled terms for the single view

benlk commented 4 years ago

Then let's :shipit: !