Closed benlk closed 4 years ago
@benlk Am I missing a setting? I checked Show share buttons above post image
and unchecked Show share counter below post
but still don't see the icons :/
Jk, apparently I had the wrong checkboxes checked. This did it
I'm seeing 2 new JS errors here coming from the child theme theme.js
theme.js?ver=1588628586:524 Uncaught ReferenceError: ajax_object is not defined
at Object.initOverlays (theme.js?ver=1588628586:524)
at Object.init (theme.js?ver=1588628586:34)
at HTMLDocument.<anonymous> (theme.js?ver=1588628586:4)
at i (jquery.js?ver=1.12.4-wp:2)
at Object.fireWith [as resolveWith] (jquery.js?ver=1.12.4-wp:2)
at Function.ready (jquery.js?ver=1.12.4-wp:2)
at HTMLDocument.J (jquery.js?ver=1.12.4-wp:2)
coming from if(ajax_object.show_post_quick_view === 'on')
and
theme.js?ver=1588628586:766 Uncaught ReferenceError: ajax_object is not defined
at Object.initAffixSidebar (theme.js?ver=1588628586:766)
at theme.js?ver=1588628586:15
at dispatch (jquery.js?ver=1.12.4-wp:3)
at r.handle (jquery.js?ver=1.12.4-wp:3)
coming from if(ajax_object.enable_sidebar_affix === 'on')
Those are probably happening because we need to redo the localize function found here that pulls in that var
It does make sense that dequeueing and deregistering the script would delocalize it as well.
58c586c65ed7c8840b55bc4b50f14d7fb26badb9 relocalizes it, as well as making sure that the child theme's JS is the one in use.
Changes
This pull request makes the following changes:
sharrre
sharing buttons from the top of postsWhy
For #9 and #GTN
Testing/Questions
Features that this PR affects:
Questions that need to be answered before merging:
Steps to test this PR:
/2020/04/reusable-protective-gear-rescue/
wp-admin/user-edit.php?user_id=140