Closed joshdarby closed 4 years ago
6ce22aa wraps the dequeue functions in a conditional that only fires if the amplify-feed query param is set. Do you think that's necessary?
Yes.
Are there any other scripts to dequeue?
I'd remove largo_header_js
from wp_enqueue_scripts
, since we aren't displaying the Largo header: https://github.com/INN/largo/blob/512da701664b329f2f92244bbe54880a6e146431/inc/enqueue.php#L177-L192
Also jquery
, jquery-migrate
, and the emoji styles, if possible.
https://github.com/INN/umbrella-inndev/pull/133/commits/e7a634ef56d67155c8c8b32acabec0c414c23a74 removes largo_header_js
, jquery
, jquery-migrate
, and all of the emoji styles and scripts.
We're down to 117.23 KB / 40.89 KB transferred on my local testing, which is gloriously small. 18.08 KB of the transferred is the header image.
Changes
This pull request makes the following changes:
Dequeues these stylesheets if the
amplify-feed
query param exists:Dequeues these scripts if the
amplify-feed
query param exists:Why
For #132
Testing/Questions
Features that this PR affects:
Questions that need to be answered before merging:
amplify-feed
query param is set. Do you think that's necessary?Steps to test this PR: