Split up grid-column-start/end declaration - Githubissues

INN / umbrella-inndev

Umbrella repository for inn.org

GNU General Public License v2.0

0 stars 1 forks source link

Split up grid-column-start/end declaration #139

Closed joshdarby closed 4 years ago

joshdarby commented 4 years ago

Changes

This pull request makes the following changes:

Splits up the grid-column: 1 /\ -1; css to be
```
grid-column-start: 1;
grid-column-end: -1;
```
since LESS didn't compile it correctly and instead of coming out as grid-column: 1 / -1 it compiles as grid-column: 1 / \ -1;, resulting in a wonky grid display

Why

For #127 ish

Testing/Questions

Features that this PR affects:

Grid column display for 2/3 rows

Questions that need to be answered before merging:

[x] Is this PR targeting the correct branch in this repository?

Steps to test this PR:

View the embed with 2 rows and then 3 rows and make sure they look as expected

benlk commented 4 years ago

Tested with:

/?amplify-feed&tag=lens-on-lightfoot&horizontal=true&rows=3 /?amplify-feed&tag=lens-on-lightfoot&horizontal=true&rows=2 /?amplify-feed&tag=lens-on-lightfoot&rows=3 /?amplify-feed&tag=lens-on-lightfoot&rows=2 /?amplify-feed&tag=lens-on-lightfoot