INN / umbrella-inndev

Umbrella repository for inn.org
GNU General Public License v2.0
0 stars 1 forks source link

Conflict between GiveWP and The Events Calendar Eventbrite Tickets plugins #57

Open benlk opened 5 years ago

benlk commented 5 years ago

With the following plugins active on WordPress 5.0.1:

$ wp plugin list --status=active
+----------------------------------------+--------+--------+---------+
| name                                   | status | update | version |
+----------------------------------------+--------+--------+---------+
| give                                   | active | none   | 2.3.1   |
| the-events-calendar                    | active | none   | 4.7.2   |
| the-events-calendar-eventbrite-tickets | active | none   | 4.5.6   |
+----------------------------------------+--------+--------+---------+
$ wp plugin list --status=active-network
+------+--------+--------+---------+
| name | status | update | version |
+------+--------+--------+---------+
+------+--------+--------+---------+

When using Give WP to create a new donation form, the options in GiveWP's custom "Donation Form Options" meta box are not saved. This is the box in its default state:

screen shot 2018-12-18 at 9 59 42 pm

If I change the selected option on any of those radio buttons and press "Save draft" or "Publish", after the editor reloads, the options are forgotten.

If I then wp plugin deactivate the-events-calendar-eventbrite-tickets, and refresh the page, the meta box shows the options I had selected when I hit save.

screen shot 2018-12-18 at 10 02 03 pm

If I then wp plugin activate the-events-calendar-eventbrite-tickets, the form returns to its default state.

Here's a list of things that are saved, which are not affected by this bug:

Which is to say: this only affects the GiveWP form, as far as I can tell.

Is it specific to a given version of WordPress?

The issue is reproduced in WordPress 4.9.9 and 5.0.1.

Is it caused by another plugin?

Referencing the list of active plugins at the top of this post, all other plugins present in the WordPress 4.9.9 production environment where this issue was noticed have been deactivated, including the network-active plugins.

Is it caused by a theme?

The problem persists when Twenty Seventeen is active

Are there any confounding issues?

Perhaps confounding this issue is that the Eventbrite "Migrate events" prompt is appearing in this editor and in all admin screens. The "Migrate events" button has been pressed, multiple times. It has not gone away.

screen shot 2018-12-18 at 10 12 41 pm
benlk commented 5 years ago

I have created this issue so that GiveWP and The Events Calendar are both operating off of the same bug report information when I submit this issue to each plugin developer, and to keep us updated as I correspond with the plugin authors.

benlk commented 5 years ago

The following bug reports have been issued:

Give WP notes on the priority support form that their staff are on holiday hours beginning this upcoming Thursday, through to the New Year, with the exception of Wednesday – Friday December 26-28.

benlk commented 5 years ago

Hi Kay,

Happy to shed some light on this issue with the Eventbright Tickets Event Calendar Pro plugin.

There is a known incompatibility with the Eventbright Tickets Event Calendar Pro plugin. Our developers found this issue and got in touch with the team over at Event Calendar Pro.

Their team assured us that the issue is going to be fixed on their end in a future release of Eventbright Tickets. In the meantime, the best way forward will be to deactivate that plugin until this issue is resolved and a fix is released.

Let me know if there is anything else that I can assist you with, and have a great rest of your day.

Thanks.

benlk commented 5 years ago

From The Events Calendar / Eventbrite:

Hi there,

Thanks for emailing support.

We are sorry to hear about the plugin conflict you have been experiencing when activating the Events Calendar Pro. I would love to help you with this topic.

As you might know, we do try hard to make our plugins compatible with as many WordPress themes and plugins as possible. This is why we take great care in following all of WordPress coding standards.

Unfortunately, as you found out, just because of the sheer number of plugins and themes out there, this is not always possible. As such, we simply cannot guarantee compatibility with themes or plugins that stray from WordPress standards.

We do have an issue with the currently migrating events and I am adding this ticket to be notified once that is fixed.

I wish I had a better answer for you, but for now it’s the best one I have.

Thanks, Brendan

benlk commented 5 years ago

From https://github.com/impress-org/give/issues/3815 9 days ago:

Hello folks—thanks all for your patience! We're hoping to include a fix for this bug into the next upcoming release of Eventbrite Tickets, which if all goes to plan should arrive some time in the next 3–4 weeks.

This would put the fix in mid-February