Add subscribe button to global and sticky nav - Githubissues

INN / umbrella-mstoday

umbrella repository for Mississippi Today https://my.wpengine.com/installs/mstoday

http://mississippitoday.org

GNU General Public License v2.0

0 stars 1 forks source link

Add subscribe button to global and sticky nav #71

Closed joshdarby closed 4 years ago

joshdarby commented 4 years ago

Changes

This pull request makes the following changes:

Adds a subscribe button to the global and sticky navs using the same approach we used for MWCIR https://github.com/INN/umbrella-mwcir/pull/34

Desktop: Screen Shot 2020-03-03 at 1 43 14 PM

Sticky: Screen Shot 2020-03-03 at 1 50 03 PM

Mobile: Screen Shot 2020-03-03 at 1 43 26 PM

Why

For #66

Testing/Questions

Features that this PR affects:

Global and sticky nav

Questions that need to be answered before merging:

[x] Is this PR targeting the correct branch in this repository?
[ ] Is /subscribe/ the correct page to point the button to?

Steps to test this PR:

View the global and sticky navs on desktop and mobile and make sure it looks ok

benlk commented 4 years ago

Note that https://github.com/INN/largo/issues/1848 will make this so much better in the future.