search

INN / umbrella-publicsource

Umbrella repository for publicsource.wpengine.com
GNU General Public License v2.0
0 stars 2 forks source link

Reorder hamburger menu contents; eliminate Global Nav "More" dropdown #21

Closed benlk closed 5 years ago

benlk commented 5 years ago

Changes

Why

For #12

benlk commented 5 years ago

The change in this branch in https://github.com/INN/umbrella-publicsource/commit/85daad28e87f920881762282509c3f2f3567006c does put the contents of the global nav before the contents of the main nav in the hamburger-menu-controlled menu on mobile, but because that menu shares markup with the sticky nav, the sticky nav also displays the global nav contents before the main nav's contents.

Here's how it looks now:

screen shot 2019-02-04 at 7 01 10 pm

And here's how it looks with https://github.com/INN/umbrella-publicsource/commit/85daad28e87f920881762282509c3f2f3567006c

screen shot 2019-02-04 at 4 00 58 pm screen shot 2019-02-04 at 4 01 18 pm

Questions for @khantasha:

khantasha commented 5 years ago

If I'm understanding this right, I think it's fine to put the global nav after the main nav in mobile as long as it's no longer contained within the More menu.

On Mon, Feb 4, 2019 at 7:56 PM Ben Keith notifications@github.com wrote:

The change in this branch in 85daad2 https://github.com/INN/umbrella-publicsource/commit/85daad28e87f920881762282509c3f2f3567006c does put the contents of the global nav before the contents of the main nav in the hamburger-menu-controlled menu on mobile, but because that menu shares markup with the sticky nav, the sticky nav also displays the global nav contents before the main nav's contents.

Here's how it looks now:

[image: screen shot 2019-02-04 at 7 01 10 pm] https://user-images.githubusercontent.com/1754187/52245346-485db780-28af-11e9-9248-fbd11f46dd6a.png

And here's how it looks with 85daad2 https://github.com/INN/umbrella-publicsource/commit/85daad28e87f920881762282509c3f2f3567006c

[image: screen shot 2019-02-04 at 4 00 58 pm] https://user-images.githubusercontent.com/1754187/52241309-4d1b6f00-28a1-11e9-87e3-b3e5d793d8b4.png

[image: screen shot 2019-02-04 at 4 01 18 pm] https://user-images.githubusercontent.com/1754187/52241310-4d1b6f00-28a1-11e9-9fc8-86a36605e3a3.png

Questions for @khantasha https://github.com/khantasha:

  • Can the global nav come at the end of the hamburger menu instead?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/INN/umbrella-publicsource/pull/21#issuecomment-460473909, or mute the thread https://github.com/notifications/unsubscribe-auth/AFDU-dSAOtm1GlEi1U4ubfKlP9xfTfgmks5vKNbMgaJpZM4aiKSO .

-- Natasha Vicens Interactives & Design Editor, PublicSource

746 E. Warrington Ave. Pittsburgh, PA 15210 @khantasha https://twitter.com/khantasha

Get the latest news from PublicSource: publicsource.org/newsletter/subscriptions http://publicsource.org/newsletter-signup

Follow us on Twitter: twitter.com/publicsourcepa

Be our fan on Facebook: facebook.com/publicsourcepa http://www.facebook.com/publicsource?ref=hl

benlk commented 5 years ago

If we change the mobile nav, the sticky nav also changes. Here's what it looks like with the global nav contents positioned after the main nav contents:

screen shot 2019-02-05 at 11 03 45 am

Note that the former "more" menu contents are now just part of that bar's contents; the "More" menu shown is the overflow menu item that appears when the menu would be too long to fit within the viewport.

screen shot 2019-02-05 at 11 48 26 am

The sticky nav is the mobile nav; the display presentation changes based on the screen width.

Is this okay? @khantasha

khantasha commented 5 years ago

Yes, that's fine. Just fyi, his looks like a really old nav we had awhile ago, the nav options are much shorter now so the display should be fine.

On Tue, Feb 5, 2019 at 2:34 PM Ben Keith notifications@github.com wrote:

If we change the mobile nav, the sticky nav also changes. Here's what it looks like with the global nav contents positioned after the main nav contents:

[image: screen shot 2019-02-05 at 11 03 45 am] https://user-images.githubusercontent.com/1754187/52289366-e13a1480-293b-11e9-8e10-7064d72b981e.png

Note that the former "more" menu contents are now just part of that bar's contents; the "More" menu shown is the overflow menu item that appears when the menu would be too long to fit within the viewport.

[image: screen shot 2019-02-05 at 11 48 26 am] https://user-images.githubusercontent.com/1754187/52289436-062e8780-293c-11e9-9cfc-13c53b689bd8.png

The sticky nav is the mobile nav; the display presentation changes based on the screen width.

Is this okay? @khantasha https://github.com/khantasha

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/INN/umbrella-publicsource/pull/21#issuecomment-460773205, or mute the thread https://github.com/notifications/unsubscribe-auth/AFDU-apcg0i64NWDSf2cElg3KZYN2Q2cks5vKdzKgaJpZM4aiKSO .

-- Natasha Vicens Interactives & Design Editor, PublicSource

746 E. Warrington Ave. Pittsburgh, PA 15210 @khantasha https://twitter.com/khantasha

Get the latest news from PublicSource: publicsource.org/newsletter/subscriptions http://publicsource.org/newsletter-signup

Follow us on Twitter: twitter.com/publicsourcepa

Be our fan on Facebook: facebook.com/publicsourcepa http://www.facebook.com/publicsource?ref=hl