INN / umbrella-sfpublicpress

San Francisco Public Press
https://sfpublicpress.org/
GNU General Public License v2.0
1 stars 4 forks source link

Series landing page: Option to show image, byline, excerpt not saving #128

Closed MirandaEcho closed 4 years ago

MirandaEcho commented 4 years ago

"I'm using alternate layout, and in the "main section" I'm checking: Show

... when I save the page those options are there, but if I go back in, they are unchecked (and I have to make sure they are checked again or else they will not show)"

joshdarby commented 4 years ago

So it looks like these options are actually saving to the DB, they're just not being reflected in the post editor.

joshdarby commented 4 years ago

@MirandaEcho tldr; this is a Largo bug. https://github.com/INN/largo/issues/1870

The options still save and work as expected, though. They just won't show that they're checked on the editor.

benlk commented 4 years ago

But if the series landing page is saved again, are the values set to the unchecked versions?

joshdarby commented 4 years ago

But if the series landing page is saved again, are the values set to the unchecked versions?

Yes :(

MirandaEcho commented 4 years ago

Is this a Largo bug, or is there anything that can be done to resolve this?

joshdarby commented 4 years ago

@MirandaEcho it's a Largo bug. See https://github.com/INN/umbrella-sfpublicpress/issues/128#issuecomment-651275915

benlk commented 4 years ago

Between this issue's https://github.com/INN/largo/issues/1870 and https://github.com/INN/umbrella-sfpublicpress/issues/130 's https://github.com/INN/largo/issues/1795, might a later chunk of work include updates to Largo and updating this site to a 0.7-prerelease version of Largo, like is the case with CIJN?