search

INN / umbrella-sfpublicpress

San Francisco Public Press
https://sfpublicpress.org/
GNU General Public License v2.0
1 stars 4 forks source link

list item circles appear before gallery items in the core Gallery block #142

Open benlk opened 4 years ago

benlk commented 4 years ago

Note the orange circles, which appear in master and in #140:

Screen Shot 2020-06-30 at 15 55 53

joshdarby commented 4 years ago

I'm not sure if there's a good and easy solution for this one, @MirandaEcho.

The easiest solution would be to just remove the orange circle for lists if it's a block gallery.

The reason it's complicated is because the <figure> element inside of the list item is display: flex; which messes with the spacing. Overriding that would mess with the placement of the image and the caption inside of the gallery which would probably lead us down a bigger rabbit hole than we want to go down.

benlk commented 4 years ago

https://github.com/INN/umbrella-sfpublicpress/blob/0541a698ede711aa4806acec25792e7e5a2052f1/wp-content/themes/sfpublicpress/less/typography.less#L93-L102

MirandaEcho commented 4 years ago

@joshdarby what's the status of this one? It wasn't on my list for prelaunch items, but it looks like maybe it was completed in which case I'll close out the issue.

joshdarby commented 4 years ago

@MirandaEcho This one was not completed yet. The other issue pertaining to the paragraphs and weird markup inside of lists was fixed. #141