Rough draft at attempting automated redirects for terms - Githubissues

INN / umbrella-sfpublicpress

San Francisco Public Press

https://sfpublicpress.org/

GNU General Public License v2.0

1 stars 4 forks source link

Rough draft at attempting automated redirects for terms #143

Closed joshdarby closed 4 years ago

joshdarby commented 4 years ago

Changes

This pull request makes the following changes:

Creates a new function sfpp_category_tag_404_override that hooks into the template_redirect filter and attempts to automate creation of a redirect for category and tag terms to /categories/ if the url ends up being a 404

Why

For #97

Testing/Questions

Features that this PR affects:

Categories and tag urls that 404

Questions that need to be answered before merging:

[x] Is this PR targeting the correct branch in this repository?
[ ] What edge cases did I forget?
[ ] What security issues does this present?
[ ] Anything we need to change in the $redirection_info array?
[x] Could anything in it be more modular? ie: should /categories/ be hardcoded or should we instead grab a specific post id and grab its permalink?

Steps to test this PR:

Attempt to go to a category/tag url that will 404, such as https://sfpp.test/category/howdyhowdyhowdy or https://sfpp.test/tag/goodbyegoodbyegoodbye
Make sure the above don't actually 404 and instead redirect to /categories/
Make sure a relevant redirect is created in the redirection plugin
Make sure no erroneous redirects are created due to weird edge cases
Make sure there are no errors thrown if the redirection plugin is disabled

benlk commented 4 years ago

should /categories/ be hardcoded or should we instead grab a specific post id and grab its permalink?

I'm fine with it being /categories/ rather than a specific post ID; this way they can change the post or set up some other redirect from /categories/ to something else.