INN / umbrella-sfpublicpress

San Francisco Public Press
https://sfpublicpress.org/
GNU General Public License v2.0
1 stars 4 forks source link

Show wpcf-shirttail field at end of post content if it exists #145

Closed joshdarby closed 4 years ago

joshdarby commented 4 years ago

Changes

This pull request makes the following changes:

Why

For #144

Testing/Questions

Features that this PR affects:

Questions that need to be answered before merging:

Steps to test this PR:

  1. View a post that has a wpcf-shirttail custom meta field, such as http://sfpublicpress.flywheelsites.com/remaking-rent-control-if-voters-approve/ (post ID 3443) and make sure it displays at the end of the post content
  2. View a post that doesn't have that custom meta field and make sure nothing funky is happening
benlk commented 4 years ago

post 31858 without custom meta looks good.

Do we want this to wrap the field output in a lightly-styled div.entry-content.wpcf-shirttail or something to help differentiate this HTML from the post content preceding it?

MirandaEcho commented 4 years ago

Current styling in the Drupal site:

Screen Shot 2020-07-01 at 2 01 17 PM

Will the italics carry through automatically? What would it take to add a simple line divider? Other suggestions? Simpler the better.

joshdarby commented 4 years ago

@MirandaEcho The italics should carry over as long as they're part of the HTML in the field. It would take ~5 minutes to add a divider line.

MirandaEcho commented 4 years ago

@MirandaEcho The italics should carry over as long as they're part of the HTML in the field. It would take ~5 minutes to add a divider line.

Great, lets do that then. Thanks!

joshdarby commented 4 years ago

@benlk @MirandaEcho https://github.com/INN/umbrella-sfpublicpress/pull/145/commits/dfb01aa0636dace9fede8cd676a4baa2b1247126 wraps the shirttail in div.wpcf-shirttail and adds an <hr/> before the shirttail content.

Screen Shot 2020-07-01 at 2 11 10 PM