Main menu revisions and updates

INN / umbrella-sfpublicpress

San Francisco Public Press

https://sfpublicpress.org/

GNU General Public License v2.0

1 stars 4 forks source link

Open benlk opened 4 years ago

benlk commented 4 years ago

[x] Dropdowns in fullscreen menu need text contrast work:
[x] remove whitespace margin at bottom of menu by applying margin-bottom: 0:
[x] Fix JS that is making it so that, on touch devices, the dropdowns do dropdown
[x] increase tap target size on b.caret in the opened hamburger menu
[x] change color of b.caret in the opened hamburger menu and maybe add a border?

benlk commented 4 years ago

Blocked by decision on what color the non-hover colors should be for dropdown text:

Screen Shot 2020-09-03 at 17 36 31

Is it okay to go with the plain orange and let the background color be the sole distinguishing factor?

kaylima commented 4 years ago

Is it okay to go with the plain orange and let the background color be the sole distinguishing factor?

Yes, orange is fine with white background for non-hover @benlk

benlk commented 3 years ago

JS issues come from much of navigation.js having a .nav-shelf selector which was removed from nav-main.php to avoid styles upon it.