search

INN / umbrella-sfpublicpress

San Francisco Public Press
https://sfpublicpress.org/
GNU General Public License v2.0
1 stars 4 forks source link

Global nav and header search #46

Closed benlk closed 4 years ago

benlk commented 4 years ago

Changes

This pull request makes the following changes:

Screen Shot 2020-01-09 at 18 14 35 Screen Shot 2020-01-09 at 18 18 36 Screen Shot 2020-01-09 at 18 19 05 Screen Shot 2020-01-09 at 18 19 14 Screen Shot 2020-01-09 at 18 19 24 Screen Shot 2020-01-09 at 18 19 29

Why

Resolves https://github.com/INN/umbrella-sfpublicpress/issues/11 Resolves https://github.com/INN/umbrella-sfpublicpress/issues/12

Testing/Questions

Features that this PR affects:

Questions that need to be answered before merging:

Steps to test this PR:

  1. check out the branch
  2. Put some menu items in the Global Nav menu
  3. In Theme Options > Basic Settings:
    • Show the donation button, give it a link
    • Set the social media URLs
    • Set the social media buttons to appear in the header
joshdarby commented 4 years ago

This does not implement the "Hot topics:" label on the left. If we want to do that, it's going to be a mess to implement, especially if it's supposed to be user-editable. #11 (comment) (well, we could make the first item in that menu italic, but then the first item there would also show up in the mobile nav. It's a bad hack.)

If we go this route, we could always hide the first item of the global nav menu in the mobile nav. But I agree it's not a great solution and will probably come back to haunt us.

benlk commented 4 years ago

Notes from today's morning meeting:

We don't need a label!