Add subtitle metabox and styling for post top section - Githubissues

INN / umbrella-sfpublicpress

San Francisco Public Press

https://sfpublicpress.org/

GNU General Public License v2.0

1 stars 4 forks source link

Add subtitle metabox and styling for post top section #53

Closed joshdarby closed 4 years ago

joshdarby commented 4 years ago

Changes

This pull request makes the following changes:

Copies subtitle metabox functionality from https://github.com/INN/umbrella-publicsource/blob/10f4b08d8bf807cd5d15d26322714b9371e6036a/wp-content/themes/theme-publicsource/inc/metaboxes.php
Copies in content-single.php partial and modifies it to fit design
Adds styling for title and subtitle

Desktop: screencapture-sfpp-test-2020-01-14-14_24_51

Mobile: screencapture-sfpp-test-2020-01-14-14_30_43

Why

For #27

Testing/Questions

Features that this PR affects:

Subtitles
Article header

Questions that need to be answered before merging:

[x] Is this PR targeting the correct branch in this repository?
[x] Does everything look ok?
[ ] Should we reduce the spacing between the nav and article title?

Steps to test this PR:

View a post with a subtitle on desktop and mobile
View a post without a subtitle on desktop and mobile

benlk commented 4 years ago

Should we reduce the spacing between the nav and article title?

I think this spacing is fine.