INN / umbrella-sfpublicpress

San Francisco Public Press
https://sfpublicpress.org/
GNU General Public License v2.0
1 stars 4 forks source link

Interal qa bug fixes #72

Closed joshdarby closed 4 years ago

joshdarby commented 4 years ago

Changes

This pull request makes the following changes:

Why

For #65

Testing/Questions

Features that this PR affects:

Questions that need to be answered before merging:

Steps to test this PR:

  1. View a category or tag archive and make sure all of the dates match the format on single posts.
  2. Add a description and featured image to a taxonomy and view its archive. Make sure it displays and looks like a single post header
  3. Add info to an author profile and view that authors page. Make sure the header area matches a single post. Also make sure the posts on the author page have the updated date format
benlk commented 4 years ago

Screen Shot 2020-05-29 at 22 35 23 With short term names, there isn't sufficient distance between the terms to prevent the orange circles running into each other.

Screen Shot 2020-05-29 at 22 40 35

The category featured headlines on category archives are offensively large.

joshdarby commented 4 years ago

With short term names, there isn't sufficient distance between the terms to prevent the orange circles running into each other.

@benlk That is updated in https://github.com/INN/umbrella-sfpublicpress/pull/72/commits/2e5f5f1991adc325a90170aa77fb67032100473a

The category featured headlines on category archives are offensively large.

@benlk That's how they already are on master and I'm not sure if updating them is in the scope for this PR, but I tried my best to update them to make them less offensive in https://github.com/INN/umbrella-sfpublicpress/pull/72/commits/fba8f1823bf7d0e702a25e91d1c2f0509902b574

benlk commented 4 years ago

Screen Shot 2020-06-01 at 12 54 43

Are we worried about the vertical vs horizontal ovals for these circles?

If not, :shipit: 👍

joshdarby commented 4 years ago

@benlk I don't think so since that's how they are on master and the staging site currently and nobody has raised a flag about them.