INN / umbrella-sfpublicpress

San Francisco Public Press
https://sfpublicpress.org/
GNU General Public License v2.0
1 stars 4 forks source link

Homepage and header spacing updates #83

Closed joshdarby closed 4 years ago

joshdarby commented 4 years ago

Changes

This pull request makes the following changes:

screencapture-sfpp-test-2020-05-28-15_46_50

Why

For #76

Testing/Questions

Features that this PR affects:

Questions that need to be answered before merging:

Steps to test this PR:

  1. View the homepage on desktop and mobile and make sure none of the spacing updates messed anything up
benlk commented 4 years ago

Using the 1025x789 browser dimensions given in https://www.whatsmybrowser.org/b/4WJEB, a couple of concerns:

Screen Shot 2020-05-29 at 13 54 22

Decreasing the global nav font size and header donate button font size to 16px clears things up down to around 993px, when the problem reoccurs until 979px when the header social buttons are hidden.

Reducing to 15px solves the problem until 825ish px, where the problem remains until 768px when the global nav is hidden and moved to the main menu.

joshdarby commented 4 years ago

@benlk That should all have been solved in #81 (since it's caused by the original header font being removed from Adobe Fonts)

joshdarby commented 4 years ago

The above should be solved now that I merged master in