search

INN / umbrella-voiceofoc

umbrella repository for Voice of OC
GNU General Public License v2.0
0 stars 1 forks source link

Office hours 2020 02 21 #41

Closed benlk closed 4 years ago

benlk commented 4 years ago

WIP PR at stopping point where we noticed #40.

Changes

This pull request makes the following changes:

Why

For #34

Testing/Questions

Features that this PR affects:

Questions that need to be answered before merging:

Steps to test this PR:

benlk commented 4 years ago

Deploying this to staging for review this afternoon.

benlk commented 4 years ago

Deployed to http://voiceofoc.staging.wpengine.com/ at c1a55df.

benlk commented 4 years ago

After this office hours, Sonya diffed the edited stylesheet on staging against the stylesheet from Git, and moved her changes into the Customizer's Additional CSS control.

At this point, if the edited stylesheet on staging is satisfactory, I'd be in favor of copying that over the new stylesheets in this Git repo, replacing the generated LESS files.

At that point, it becomes a question of whether we want to invest the time involved in backporting the CSS changes to LESS. That's a massive undertaking if there are extensive differences.

If Voice of OC plans to continue editing their CSS stylesheets by hand, I do not think we should plan to use LESS in this repo in the future, because we'd have to monitor the stylesheets for changes and backport them to the LESS. If they continue editing the CSS by hand, the CSS becomes the source of truth rather than the LESS, and there's no point maintaining the LESS anymore. Delete the LESS, delete Grunt, and remove the minified style.min.css from the staging site so that there's no confusion about whether the minified or the unminified file is canonical. Let there be only one CSS file.

benlk commented 4 years ago

To make it easier to compare staging and prod and git in the future:

benlk commented 4 years ago

Stylesheets on staging were not edited, and functions.php currently points to style.css. No changes are necessary at this time, so I'm not going to delete Grunt or LESS just yet.

I will include the fix for #36 and https://github.com/INN/largo/issues/1855 from https://github.com/INN/umbrella-mstoday/pull/73.

benlk commented 4 years ago

This is currently deployed to staging and approved by Sonya.