Change codestyle according to guidelines

INPStarfall / Starfall

Starfall Processor for Garry's Mod + Wiremod

http://www.wiremod.com/forum/developers-showcase/22739-starfall-processor.html

Other

17 stars 15 forks source link

Change codestyle according to guidelines #7

Open Xandaros opened 10 years ago

Xandaros commented 10 years ago

Currently the codestyle is inconsistent, this needs to be changed...

[x] Hologram entity
[x] Processor entity
[x] Screen entity
[x] Processor STool
[x] Screen STool
[x] ents lib cl
[x] render lib cl
[x] builtins lib sh
[x] ents lib sh
[x] files lib sh
[x] find lib sh
[x] globaltables lib sh
[x] holograms lib sh
[x] hook lib sh
[x] net lib sh
[x] players lib sh
[ ] quaternion lib sh
[ ] serverinfo lib sh
[ ] sound lib sh
[x] timer lib sh
[x] trace lib sh
[ ] vmatrix lib sh
[ ] von lib sh
[x] ents lib sv
[x] wire lib sv
[x] callback.lua
[x] compiler.lua
[ ] editor.lua
[x] instance.lua
[x] libraries.lua
[ ] permissions.lua
[x] preprocessor.lua
[x] sflib.lua

Xandaros commented 10 years ago

Feel free to help me out, choose one or more files, leave a comment here and pull request it into https://github.com/Xandaros/Starfall/tree/codestyle

Might want to wait till we have the code style set in stone, though...

Edit: In fact, I'm going to put this on hold until then

daranable commented 10 years ago

We should talk about this ASAP. as if there are significant changes to any files I am working on for coroutines then merging them will be annoying at best.

Xandaros commented 10 years ago

Yes, I can see that being a problem... I suggest we finish any development and then get the code according to guidelines. Which means it might still be a while, don't know how far you are with your coroutines...

daranable commented 10 years ago

Actually, I haven't done much. If you get the core files up to standards asap, that will probably be better, and then I'll get the coroutines going..

awilliamson commented 10 years ago

I'll try to get some done later today after meetings. Especially code which I've majorly developed, so quats/holos/vmatrix/ents/von.

Xandaros commented 10 years ago

Ok, good. @daranable I still need your opinion on the function argument list style, though...

Xandaros commented 10 years ago

I think everything is clear now, so I'll continue work on this. Too bad I can't find a decent beautifier :/

wraith321 commented 10 years ago

Well you could define all the rules in regular expressions, that should be way faster than manual editing. NPP has basic functionality for this but there are better programs for this I guess.

Xandaros commented 10 years ago

The problem is, that starfall does not have a uniform codestyle... Also, apparently all my work on the codestyle so far is gone - no idea why. It's even missing locally, like I never did anything -_-