search

INRIA / scikit-learn-mooc

Machine learning in Python with scikit-learn MOOC
https://inria.github.io/scikit-learn-mooc
Creative Commons Attribution 4.0 International
1.12k stars 516 forks source link

feat: Adds license to jupyter-book config #682

Closed darigovresearch closed 1 year ago

darigovresearch commented 1 year ago

Relevant to issue #681

lesteve commented 1 year ago

Thanks for your suggestion, I checked what the Turing Way book is doing and it does not mention its license in its footer but only in one of its page, as we already do for this repo.

I would be in favour of not adding the licence to the footer in the but I'll let others pitch in if they have a strong opinion.

ArturoAmorQ commented 1 year ago

I am also fine with just mentioning the license on the index, but I am open to adding it if we have a good reason why users would benefit of the increased visibility.

darigovresearch commented 1 year ago

@lesteve & @ArturoAmorQ thanks for adding your comments. It is very common to make the license explicit (and more discoverable) in the footer as it encourages people to build on top of your work (such as translations, condensed code etc), submit corrections and code fixes.

darigovresearch commented 1 year ago

@ArturoAmorQ thanks for the merge !