search

INRIA / scikit-learn-mooc

Machine learning in Python with scikit-learn MOOC
https://inria.github.io/scikit-learn-mooc
Creative Commons Attribution 4.0 International
1.12k stars 516 forks source link

ENH new non-linear engineering for LogisticRegression #711

Closed glemaitre closed 1 year ago

glemaitre commented 1 year ago

Towards #707

ogrisel commented 1 year ago

@glemaitre @ArturoAmorQ I think this is ready for review. I plan to open dedicated PRs to address the remaining items of #707.

ogrisel commented 1 year ago

@ArturoAmorQ I think all the comments that are directly related to this particular notebook have been addressed and this PR is ready for final review and merge.

I will open follow-up PRs to update the other notebooks (e.g. transform the kernel notebook into an exercise (https://github.com/INRIA/scikit-learn-mooc/pull/711#discussion_r1319817018) and introduce splines in the previous notebook(s) where appropriate (https://github.com/INRIA/scikit-learn-mooc/pull/711#discussion_r1319796526).

ogrisel commented 1 year ago

Thanks very much for the fixes and improvements Arturo.

ArturoAmorQ commented 1 year ago

Thanks @glemaitre and @ogrisel :) I am merging this one.