Closed monperrus closed 2 years ago
1 alert of Arbitrary file write during archive extraction ("Zip Slip") 1 alert of Array index out of bounds in SnippetCompilationHelper.java 2 alerts of Container contents are never accessed across 2 files 2 alerts of Inconsistent equals and hashCode across 2 files 17 alerts of Dereferenced variable may be null across 4 files 2 alerts of Potential output resource leak across 2 files 1 alert of Useless type test i nClassTypingContext.java
I created PRs for the following problems: 1 alert of Arbitrary file write during archive extraction ("Zip Slip") #4199 1 alert of Useless type test i nClassTypingContext.java #4196 2 alerts of Potential output resource leak across 2 files #4197 2 alerts of Container contents are never accessed across2 files #4198
PS: Could we add either add hacktoberfest
to the topic or create a label hacktoberfest-accepted
. Either will let my PRs count for the project.
A repository/project is considered to be participating in Hacktoberfest if the 'hacktoberfest' topic is present and is accepting public contributions via pull requests. An individual pull request can also be opted-in directly by adding the 'hacktoberfest-accepted' label.
I could fix the rest, but I would leave them as a free Hacktoberfest opportunity for some java starters. If no one fixes them I go back to them in November.
Nice! Your work is much appreciated.
FYI, it is planned to add support for automatically repairing LGTM warnings in Sorald, see https://github.com/SpoonLabs/sorald/issues/607 (maybe a master's thesis topic?)
Can i try this one?
Sure, go ahead.
Per https://github.com/INRIA/spoon/issues/4275#issuecomment-967286718 and https://github.com/INRIA/spoon/issues/4275#issuecomment-967437353 we are now deactivating lgtm.
So, feels like we should close this as we don't use LGTM anymore.
FYI, activated static analysis by LGTM, out of curiosity
https://github.com/marketplace/lgtm
Will deactivate if annoying