search

INRIA / spoon

Spoon is a metaprogramming library to analyze and transform Java source code. :spoon: is made with :heart:, :beers: and :sparkles:. It parses source files to build a well-designed AST with powerful analysis and transformation API.
http://spoon.gforge.inria.fr/
Other
1.76k stars 352 forks source link

configure renovate to only use chore(deps) #5952

Closed monperrus closed 2 months ago

monperrus commented 3 months ago

renovate creates PR with both chore(deps) and fix(deps) as commit message.

this pollutes our changelogs eg https://github.com/INRIA/spoon/releases/tag/v11.1.1-beta-2

I would argue that dependency updates are not fixes is the sense we mean it, and that all renovate PRs in our changelogs should be under Tasks

task: configure renovate to only use chore(deps)

reference documentation: https://docs.renovatebot.com/semantic-commits/

cc/ @rarkins FYI

rarkins commented 2 months ago

In semantic versioning, chore commits don't increment a version while fix ones do. Technically speaking a production dependency update can change functionality and therefore should trigger a new version. I prefer to use build than fix for my own projects, but still to trigger a version.

monperrus commented 2 months ago

I understand that you're referring to "dependency-aware semver", where a major/minor change in a dependency triggers a corresponding version update in the project, as a ripple effect. That's an interesting pov to discuss.

Also, we agree that fix is not the best prefix for commit messages and changelog generation, I like your proposal of having build, it's even better than chore.

monperrus commented 2 months ago

PR at https://github.com/INRIA/spoon/pull/5953