Fix SortedList.addAll(...) to be JLS compliant and provide unit tests

INRIA / spoon

Spoon is a metaprogramming library to analyze and transform Java source code. :spoon: is made with :heart:, :beers: and :sparkles:. It parses source files to build a well-designed AST with powerful analysis and transformation API.

http://spoon.gforge.inria.fr/

Other

1.76k stars 352 forks source link

Fix SortedList.addAll(...) to be JLS compliant and provide unit tests #6046

Closed CoreRasurae closed 3 weeks ago

CoreRasurae commented 3 weeks ago

Fixes #6034
SortedList.addAll(...) should return a boolean value indicating if the Collection was modified is any way as a result of the call.
Previously addAll(...) would return false if only partial changes occurred and would only return true if all elements had been inserted, or if adding an empty list which in not in accordance to the Java JLS/API as documented in https://docs.oracle.com/javase/8/docs/api/?java/util/Collections.html.

CoreRasurae commented 3 weeks ago

Sorry i will redo all this