search

INRIA / spoon

Spoon is a metaprogramming library to analyze and transform Java source code. :spoon: is made with :heart:, :beers: and :sparkles:. It parses source files to build a well-designed AST with powerful analysis and transformation API.
http://spoon.gforge.inria.fr/
Other
1.76k stars 352 forks source link

review: fix: Use new line symbol from system also for BLOCK comments when printing #6052

Closed GooDer closed 3 weeks ago

GooDer commented 3 weeks ago

I encounter small problem when I tried to output processed classes to disk.

There are comments which I think have sort of bad syntax 

/* (non-Javadoc)
  @see com.some.package.SomeObject#getSomeField()
 */
@Transient
public Long getSomeField() {
.......
}

Due to missing 'star' in the middle line it is marked as BLOCK comment. Later during processing of printing of comments there is hardcoded CtComment.LINE_SEPARATOR for new lines which will not match rest of the class which is written with system specific new line symbol (windows \r\n\ in my case).

This will mark class as changed in Git due to this change in new line character.

Every where in comments in the code is written that these hardcoded new line \n should not affect how comments are rendered so I guess it is bug.

MartinWitt commented 3 weeks ago

Thanks @GooDer