INSPIRE-MIF / 2017.2

Repository for action 2017.2 on alternative encodings
6 stars 11 forks source link

Confusion of 'feature' and geometry in Alternate Encoding for INSPIRE Data: GeoJSON #40

Closed PeterParslow closed 5 years ago

PeterParslow commented 5 years ago

The introduction of https://github.com/INSPIRE-MIF/2017.2/blob/master/GeoJSON/specification.md currently says "The features include points (therefore addresses and locations), line strings (therefore streets, highways and boundaries), polygons (countries, provinces, tracts of land), and multi-part collections of these types."

Just like 'our' other standards, GeoJSON distinguishes between Feature Objects and Geometry Objects. "A Feature object has a member with the name "geometry". The value of the geometry member SHALL be either a Geometry object as defined above or, in the case that the Feature is unlocated, a JSON null value." (https://tools.ietf.org/html/rfc7946#section-3)

Therefore, it's better to say something like "GeoJSON Geometry Objects may be points (which can be used for features like addresses and locations), line strings (e.g. for streets, highways, boundaries), polygons (countries, provinces, tracts of land), and multi-part collections of these types."

PeterParslow commented 5 years ago

I'm not quite content that this pull request fixes this comment. See https://github.com/INSPIRE-MIF/2017.2/commit/94239de4aa1e8a5c72e2ff6bbb7c96f7deb29fe1#commitcomment-31700462