INSPIRE-MIF / 2017.2

Repository for action 2017.2 on alternative encodings
6 stars 11 forks source link

Missing Observing Capabilities in EF #86

Closed KathiSchleidt closed 4 years ago

KathiSchleidt commented 5 years ago

In the EF Model, the ObservingCapabilities FT was created to provide measurement metadata describing HOW (procedure) was WHAT (observedProperty) measured WHERE (featureOfInterest); these three associations mirror the associations of the same name defined for the O&M Observation. While unfortunately not formalized as a constraint, there is a clear statement in the DataSpec that "Consistency has to be assured between links from class ObservingCapability and observations." The result is that you have a description of a facility where you know the location and media monitored (in the example "water"), but not what is being measured. Where this is really an issue is example 1, which provides a value with UoM, but no information on what was actually measured.

michellutz commented 5 years ago

Indeed, while the mapping table for EnvironmentalMonitoringFacility has an entry for the observingCapability property, it is not clear what type this is mapped to in GeoJSON (the table says "ObservingCapability", but this is not further defined in the spec). The complex type should either be represented as a string (then we would need to define how) or, maybe better, split into several properties.

The examples should also be updated to include this property.

KathiSchleidt commented 5 years ago

I could see flattening the ObsCaps attributes into the basic EF FT, as long as there is only one ObsCaps per EF Question is what you do when one EF measures multiple ObservedProperties. With complex features, we foresaw 2 models:

  1. One EF FT per ObservedProperty, all linked to a higher level EF FT for the entire station via the broader<->narrower association (this is the reason the ObsCaps are nominally optional as the higher level EF does not provide this information, just refers to its narrower children and their ObsCaps)
  2. One EF FT for all ObservedProperties, whereby one ObsCaps is to be provided per ObservedProperty - not sure if an array of ObsCaps in the properties section would really be useful

Would option 1 work with simple features?

thorsten-reitz commented 5 years ago

I've added the Observing Capabilities to the profile. Please review (PR coming in a moment) and feel free to suggest how to apply that to the examples.

thorsten-reitz commented 4 years ago

Closing this since PR was merged and no further feedback given.

KathiSchleidt commented 4 years ago

Would have been nice if this was also added to the examples as would make for better understanding. Also - have you foreseen what you do when an EF measures multiple properties?