search

INSPIRE-MIF / application-schemas

Community for the discussion of change proposals to the INSPIRE XML schemas.
https://inspire.ec.europa.eu/schemas
8 stars 10 forks source link

PF_ProductionFacility_groupingFacility association missing #126

Open JohannaOtt opened 1 month ago

JohannaOtt commented 1 month ago

Change proposal description

Issue faced

According to the UML diagram, ProductionInstallation should have an association called groupingFacility linking to the respective ProductionFacility object. But in the related xsd, no such association is defined.

Expected behaviour

I would expect ProductionFacility.groupingFacility to be contained in the xsd file

Current behaviour

ProductionFacility.groupingFacility is missing in the xsd file

Proposed solution

Add groupingFacility to the xsd file

Additional information

Proposal reason

I think it is a bug that the xsd file does not reflect what is defined in the respective UML model. It would be really useful for data users IMO to have a link to the ProductionFacility a ProductionInstallation belongs to.

Addressed schema

ProductionAndIndustrialFacilities.xsd

Impact on INSPIRE TG / IR

Change proposer

The groupingFacilityassociation would also need to be added to the Implementing rules as well as the Data specification

fabiovinci commented 1 month ago

Dear @JohannaOtt,

thank you for your proposal. It is similar to issue #123 already discussed and rejected by the Sub-group.

It seems that all the associations in the PF data model were modelled as "navigable only in one direction", as recommended in the Generic Conceptual Model document.

In any case, the proposal will be discussed in the next Sub-group meeting.

JohannaOtt commented 1 month ago

@fabiovinci Thanks a lot for the quick response and the link to the other issue. I seemed to remember that something similar had been discussed but did not find it with my keywords ;) If it is decided to go with associations in one direction, I would change this CR to remove the additional associations from the UML model. This way implementers will not be confused any longer.