INSPIRE-MIF / caniuse

Which INSPIRE GML and GeoJSON features can I use in which software?
5 stars 8 forks source link

GeoJSON Sample Data Feedback #21

Open jsaligoe opened 5 years ago

jsaligoe commented 5 years ago

Sample Data Feedback Issue applies to: Sample data 'geojson_property_extraproperties.json'

Sample data field names use reserved characters

In the sample data, the feature object “id” uses commonly reserved characters and symbols, e.g., “$”, in field names. The supplied file uses the identifier “$id”. A “$” sign is widely used in software to denote variable substitution, this is asking for fragility.

Similarly, the properties use object names “_type” and “$type” and recycle the identifier “id” [1]. The latter should be OK as you’re within a property array. But using identifiers closely confounded with a common database reserved word, a common variable substitution syntax and an easily missed (when displayed or printed) underscore character is again risking fragility.

To promote the greatest level of interoperability in mainstream web and desktop GIS clients, we recommend:

--

[1] The GeoJSON Format. Section 3.2 Feature Object: https://tools.ietf.org/html/rfc7946#page-11

[2] ArcGIS Field Naming Guidelines https://desktop.arcgis.com/en/arcmap/latest/manage-data/tables/fundamentals-of-adding-and-deleting-fields.htm#GUID-8E190093-8F8F-4132-AF4F-B0C9220F76B3

alexanderkotsev commented 5 years ago

@jsaligoe thanks for the issues raised. Please note that the 'geojson_property_extraproperties.json' file was initially committed when the repository was established so is a bit outdated. I will remove it out in order to avoid confusion in the future. INSPIRed GeoJSON for testing is available in the Alternative Encodings for INSPIRE data repository for two themes (Environmental Monitoring Facilities, and Addresses).

In particular on the issues raised: 1) use of special symbols in property names - we experienced the same issue with the use of '.' in other products as well. Would an '_' work as part of the name for the ArcGIS products?

  1. On the inclusion of a feature member that contains the "id". The examples of INSPIRed GeoJSON data available in the Alternative Encodings for INSPIRE data repository already contain an 'id' feature member, so I think there is no issue with that.
jsaligoe commented 5 years ago

@alexanderkotsev Thanks, we will omit this in our testing. Yes, the '_' underscore is supported in ArcGIS and would promote the greatest level of interoperability among the widest variety of GIS clients. I've added a recommendation for 2017.2 model simplification rules that lists characters to avoid, as well as reserved keywords, etc.