search

INSPIRE-MIF / helpdesk-validator

Community discussion forum for INSPIRE validation issues
42 stars 23 forks source link

Pre-defined WFS test - Analyze WFS capabilities issue #164

Open VeronikaKusova opened 5 years ago

VeronikaKusova commented 5 years ago

I have been testing our WFS (Pre-defined WFS) and I think there is an error in a test step “Analyze WFS Capabilities” (and "Get number of features in DB" consequently). Our services fail the test step the same way – "Get number of features in DB" is invoked and passed, but just after that the test fails with messages “error at line: 28” and “java.lang.AssertionError: Failed to initialize Executable Test Suite. Expression: (completed == autoConfiguration). Values: autoConfiguration = Cannot invoke method getNamedItem() on null object”. If I understand correctly (but maybe I am wrong), a request for getting number of features is done by requestNumberOfFeatures method from https://github.com/etf-validator/etf-sui-ae/blob/3ffa7399b13d0c4a80cffc9f10d4bb948a206ade/etf-sui-owsgtl/src/de/interactive_instruments/xtf/wfs/Capabilities.groovy . And I found an issue there.

There is a problem, that the method uses the first child (getFirstChild()) from the response (see picture below). And in our services there is a comment (with an information about version of map server etc.) on the place of the first child. When I run this part of the method on an XML response without the comment, it works properly.

In case of our services it is not possible to delete the comment from their responses easily. So I can’t test the same service with this change. So I am not 100 % sure.
image

Service endpoint: http://services.cuzk.cz/wfs/inspire-AU-wfs.asp?service=WFS&request=getCapabilities

Response for getting number of features: http://inspire.ec.europa.eu/validator/v2/TestTaskResults/EID0c8d675a-c760-465d-a7a4-36274bfadbd8/Attachments/EID0f2fdc4e-99ff-4c2f-b5fa-fcc9e8fa14cf

Test report: http://inspire.ec.europa.eu/validator/v2/TestRuns/EIDfa2684c6-51a6-4888-8140-069d803b9910.html

I would like to ask, if I am right regarding the issue?

Thanks. Veronika

danielnavarrogeo commented 5 years ago

Dear @VeronikaKusova, Thank you for you clear description about the issue. We are currently analyzing the problem and we will come back to you as soon as possible. Regards

VeronikaKusova commented 5 years ago

Dear @danielnavarrogeo, thank you for your responce. I have continued to investigate this issue. I have tried to test it on a different service, that runs on a different map portal (so I can change its responces more easily). If I test this service and if there isn't any comment on the first position in the GetFeature response, it passes the whole Initialization and basic checks test module. But if I add a comment in the GetFeature response (on the first position), the test fails the same way as I have reported before (in the same test step with the same error messages etc.).

I can't send you a link to this "testing" service, because it is not open to public. But I hope this information will help you anyway.

Regards. Veronika

josemasensio commented 5 years ago

Dear @VeronikaKusova,

Please, in order to reproduce the error on our environment, would you mind to provide us with the data by email sending them to inspire-helpdesk@bilbomatica.com. All data sent to this address will be completely confidential and will only be used in order to improve the validator. Once the issue has been solved all data will be deleted.

Thank you and best regards.

VeronikaKusova commented 4 years ago

@josemasensio, do you mean/want service endpoint of my testing service? But at the moment there is a comment on the position of the first child in the GetFeature response, so the test fails the same way as this service: http://services.cuzk.cz/wfs/inspire-AU-wfs.asp?service=WFS&request=getCapabilities Or do you want me to delete the comment in the testing service and send you the link? Or do you need anything else?

josemasensio commented 4 years ago

Dear @VeronikaKusova,

I can't send you a link to this "testing" service, because it is not open to public. But I hope this information will help you anyway.

I was refering to this service, apologise if my requirement was not clear.

Best regards.

danielnavarrogeo commented 4 years ago

Dear @VeronikaKusova

We are working on this issue. We will come back to you when a solution is implemented.

Regards

josemasensio commented 4 years ago

Dear @VeronikaKusova,

We noticed that the service has changed. Please, could you provide us with the service again? If you prefer, you can provide us the service as a file and we will deploy this on our local environment.

Thank you and best regards.

VeronikaKusova commented 4 years ago

Dear @josemasensio, I am sorry for those changes, but we wanted to move forward in testing.

We provide some other services with the same issue and the changes haven’t been done there, yet. (All these services run on the same map server). Access points to these services: http://services.cuzk.cz/wfs/inspire-CP-wfs.asp?service=WFS&request=getCapabilities http://services.cuzk.cz/wfs/inspire-BU-wfs.asp?service=WFS&request=getCapabilities

Can you use them instead of the original service? I run the ETS for Pre-defined WFS in Soap-UI and it seems these two services have the exact issues as the original one. So, I hope you can use them instead.

I apologize for the inconvenience. Best regards.