INSPIRE-MIF / helpdesk-validator

Community discussion forum for INSPIRE validation issues
42 stars 22 forks source link

md common req C.11: Temporal Reference #202

Closed alitka closed 4 years ago

alitka commented 4 years ago

Issue related to https://github.com/inspire-eu-validation/community/issues/175

To avoid this error, you have to change the codeListValue to "publication", but this couldn't be the solution! Could you check C.11 in combination with C.12 and C.13, please?

Thanks & regards.

danielnavarrogeo commented 4 years ago

Dear @alitka

The issue has been addressed and deployed in staging environment.

Could you please check it and confirm that the issue has been fixed?

Regards

alitka commented 4 years ago

Dear @danielnavarrogeo, I have tested the xml-files again, addional another xml-file also and everything is working properly. Thanks and best regards!

danielnavarrogeo commented 4 years ago

Thank you @alitka for your feedback.

Regards

fabiovin commented 4 years ago

Dear @danielnavarrogeo, I have tested (in staging) the attached service metadata file in which all the three dates (creation, publication and revision) are present in the element:

      <gmd:identificationInfo>
            <srv:SV_ServiceIdentification>
               <gmd:citation>
                  <gmd:CI_Citation>

One of them (revision) is encoded as <gco:DateTime>, this is correct but the validator throws an error for C.11 (http://staging-inspire-validator.eu-west-1.elasticbeanstalk.com/etf-webapp/v2/TestRuns/EIDebddc447-d571-48a3-aef5-60771b920289.html).

If I try to encode it as <gco:Date> the error disappears (http://staging-inspire-validator.eu-west-1.elasticbeanstalk.com/etf-webapp/v2/TestRuns/EIDe2cc00aa-77af-4c2d-b2df-98232856d031.html).

Could you please verify?

Thanks

1.iso19139_mod_C.11-test.xml.zip

danielnavarrogeo commented 4 years ago

Dear @fabiovin

We will verify it and keep you posted.

Regards

danielnavarrogeo commented 4 years ago

Dear @fabiovin

The error is due to not accepting a DateTime element without defining the time zone.

The following element is currently throwing an invalid date output:

<gco:DateTime>2013-09-30T11:15:00</gco:DateTime>

While adding Z or time zone validates properly:

<gco:DateTime>2013-09-30T11:15:00Z</gco:DateTime>

and

<gco:DateTime>2013-09-30T11:15:00+07:00</gco:DateTime>

We think the first option is also valid, as ISO 8601 considers that as a special case for local times. Therefore, we are going to update the test to accept that format as well.

Regards

danielnavarrogeo commented 4 years ago

Dear @fabiovin

The DateTime without timezone is now accepted.

You can check it in staging environment.

Regards

fabiovin commented 4 years ago

Dear @danielnavarrogeo,

I tested it and now the C.13 fails (http://staging-inspire-validator.eu-west-1.elasticbeanstalk.com/etf-webapp/v2/TestRuns/EIDdbdaf2e1-f5a2-40ee-a06c-586915d0b06c.html), with the same behaviour, if I encode the element as the errors disappears.

danielnavarrogeo commented 4 years ago

Dear @fabiovin

It seems there was an error rebuilding staging.

We will rebuild it again and tell you when you can check it.

Regards

danielnavarrogeo commented 4 years ago

Dear @fabiovin

You can check it again.

Sorry for the inconvenience.

Regards

fabiovin commented 4 years ago

Dear @danielnavarrogeo, no problem! Now it works!

danielnavarrogeo commented 4 years ago

Thank you @fabiovin for your feedback.