INSPIRE-MIF / helpdesk-validator

Community discussion forum for INSPIRE validation issues
42 stars 23 forks source link

Metadata dataset: The attribute code list is not correct #69

Closed idevisser closed 4 years ago

idevisser commented 5 years ago

I got on several metadata elements the unexpected error The code list attribute is not correct. The attribute code list shall be 'http://standards.iso.org/iso/19139/resources/gmxCodelists.xml#XXXXX'

TG Requirement C.3: metadata/2.0/req/common/code-list-value The code list value shall be encoded using the codeListValue attribute of the relevant ISO 19139 element. The value shall be the identifier of the code list value, as defined in the name column of the tables in [ISO 19115], Annex B.

This requirement requires only a correct value

As the TG metadata further describes;

Both the value of the codeList attribute (a URL that references a code list definition within a register or a code list catalogue) and the textual content of the ISO 19139 element are purely informative. The codeList value may e.g. point to the code list dictionary in the ISO 19139 repository at http://standards.iso.org/iso/19139/resources/codelist/, and if a text is provided, it may contain the translation of the code list value in the language of the metadata.

The validation check on the attribute codelist looks like not correct

josemasensio commented 5 years ago

Dear @idevisser,

Thank you for your message. We have checked the TG and it seems that you are right.

Could you send us a metadata example please? We need it to test on the validator and check the error.

Best regards.

idevisser commented 5 years ago

Hello

Herby the complete metadata example file, used by all issues I reported yesterday.

test dataset.zip

Best regards Ine

idevisser commented 5 years ago

Hi,

Same problem with the service metadata, Is it necessary to make a separate issue for that?

Best regards Ine

josemasensio commented 5 years ago

@idevisser after reviewing the ATS of Metadata Point of Contact and the inspire-tg-metadata-iso19139-2.0.1 (page 34), in both it is said that 'the attribute codeList of the Role node is "http://standards.iso.org/iso/19139/resources/gmxCodelists.xml#CI_RoleCode"'.

So you should change the values of the codeList attributes in gmd:CI_RoleCode elements to solve the error, "http://standards.iso.org/iso/19139/resources/gmxCodelists.xml#CI_RoleCode" instead of "http://www.isotc211.org/2005/resources/Codelist/gmxCodelists.xml#CI_RoleCode".

Best regards.

idevisser commented 5 years ago

Can you tell me in which requirement you find this? I can't find it (on page 34)

josemasensio commented 5 years ago

I attach an image.

RoleCode

idevisser commented 5 years ago

ah, I see it's in the foodnotes, but this is not in line with wat is written in chapter 2.1.1 Encoding of code list values of the TG. There is a clear statement that "Both the value of the codeList attribute (a URL that references a code list definition within a register or a code list catalogue) and the textual content of the ISO 19139 element are purely informative."

So I can't agree on a test that refuse the same codelists, published by international standardisation organisations on another location.

michellutz commented 5 years ago

I think this issue should be discussed in the 2017.4 sub-group.

AntoRot commented 5 years ago

A similar discussion (with regard to language code) was addressed in the issue #52. I agree that the test should only check if the codeListValue is one of the values coming from the ISO Standard (as code lists and their values provided in ISO Standard 19115 are normative, as we can read in the section 6.7 in that Standard) and no check should be done on codelist attribute, except for language metadata element for the reasons I explained in the mentioned issue #52. Consequently the footnotes should be reworded to be aligned to the TG section 2.1.1.

LauraAlemany commented 5 years ago

I agree with Antonio,

The footnotes should be reworded to be aligned to the TG section 2.1.1.

Best regards, Laura

MarcoMinghini commented 5 years ago

2017.4 meeting 2019-07-17

josemasensio commented 5 years ago

Dear @idevisser,

We uploaded the solution to staging instance. Can you try here and give your feedback?

Regards.

josemasensio commented 5 years ago

Afert some internal tests, we checked that everything is working fine, so we will mark as solved this issue.

Regards.

danielnavarrogeo commented 5 years ago

Now the codeList is only checked in 'C.5 Language Code' and '1.6 Resource Language' tests. https://github.com/inspire-eu-validation/community/issues/131