INSPIRE-MIF / technical-guidelines

Community for the discussion of change proposals to the INSPIRE Technical Guidance documents.
https://inspire-mif.github.io/technical-guidelines
29 stars 15 forks source link

TG Download - dataset identifier namespace is optional #82

Closed heidivanparys closed 9 months ago

heidivanparys commented 1 year ago

Change proposal description

The namespace component of the dataset identifier is optional, the requirements in the TG Download should reflect this.

Addressed TG

Technical Guidance for the implementation of INSPIRE Download Services

Location

Make spatial_dataset_identifier_namespace optional in requirements 13, 42, 43, 44, 50 and 51.

Issue faced

The namespace component of the dataset identifier is optional, in fact it is actually recommended to have a dataset identifier that is encoded in one string, containing both namespace and code, see https://inspire-mif.github.io/technical-guidelines/metadata/metadata-iso19139/metadata-iso19139.html#_unique_resource_identifier. The requirements in the TG Download do not reflect this.

Proposed solution

Update of the TG requirements 13, 42, 43, 44, 50 and 51 and the surrounding text, see pull request.

Pull request

83

Additional information

Relevant legislation

https://eur-lex.europa.eu/legal-content/EN/TXT/?uri=CELEX:02008R1205-20081224

Impact on IR

N/A

Impact on INSPIRE validator

Impact on:

Linked issue

https://github.com/INSPIRE-MIF/helpdesk-validator/issues/124 https://github.com/inspire-eu-validation/download-service/issues/89

Impact on INSPIRE XML schemas

N/A

Impact on INSPIRE code lists

N/A

Change proposer

Heidi Vanparys, Danish Agency for Data Supply and Infrastructure

References

N/A

heidivanparys commented 1 year ago

To ease the discussion, some examples below.

DK INSPIRE Administrative units has the following spatial data set identifier:

billede

billede

This is in accordance with the recommendation to have a dataset identifier that is encoded in one string, containing both namespace and code, see https://github.com/INSPIRE-MIF/technical-guidelines/blob/2022.2/metadata/metadata-iso19139/metadata-iso19139.adoc#3121-unique-resource-identifier.

In the Atom feed, the spatial data set identifier is currently indicated as follows:

billede

So the spatial_dataset_identifier_namespace element is not present here.

However, this conflicts with the requirement in section Download Service Feed: feed 'entry' element:

billede

In comparison, INSPIRE - Unités Administratives - UrbIS has the following spatial data set identifier:

billede

billede

This spatial data set identifier is also compliant to the INSPIRE specifications, it's just another way of encoding it.

In the Atom feed, the spatial data set identifier is currently indicated as follows:

billede

fabiovinci commented 1 year ago

Sub-group meeting on 17.04.2023: the issue was discussed in the sub-group and it was decided to postpone it to better verify if there are implications in other requirements of the same TG and/or in other TGs.

fabiovinci commented 1 year ago

According to this change proposal, Requirement 44 should also be reformulated.

image

fabiovinci commented 1 year ago

The change should also involve Requirement 43 since the Validator checks the mandatory presence of the "spatial_dataset_identifier_namespace" element in the Get Spatial Data Set template.

image

heidivanparys commented 1 year ago

This also affects requirement 42. I've updated the change proposal and the pull request.

fabiovinci commented 1 year ago

Sub-group meeting on 10.11.2023: the Sub-group approved this change proposal.

sMorrone commented 12 months ago

During the joint MIG/MIG-T meeting held on 30/11/2023, the proposal was endorsed. More details in the minutes of the 76th MIG-T meeting

fabiovinci commented 6 months ago

It seems that this issue also has an impact on schemas. In particular, the schema https://inspire.ec.europa.eu/schemas/inspire_dls/1.0/inspire_dls.xsd defines elements to be used in an ATOM feed and the attribute spatial_dataset_identifier_namespace is mandatory.

Even if the schema is not used for ATOM validation, it is worth modifying it by setting the attribute spatial_dataset_identifier_namespace as optional.

image

On the contrary, the type inspire_common:uniqueResourceIdentifier defined by the https://inspire.ec.europa.eu/schemas/common/1.0/common.xsd schema and used for the SpatialDataSetIdentifier attribute of the WMS/WFS Extended capabilities is already correctly defined, i.e. the attribute inspire_common:Namespace is optional.

image