Improve saving tsv files and add unittests - Githubissues

INT-NIT / BEP032tools

Software tools supporting the BIDS Extension Proposal (BEP) dedicated to adding support for electrophysiological data recorded in animal models (BEP032)

MIT License

3 stars 9 forks source link

Improve saving tsv files and add unittests #107

Open JuliaSprenger opened 2 years ago

JuliaSprenger commented 2 years ago

The save_tsv function does not properly handle Dataframes with different data types leading to wrong Dataframe comparisons. In the Templater this currently requires a hacky solution (see https://github.com/INT-NIT/BEP032tools/blob/c135011556278f5e449491f4fe4333f4c3a2a74d/ando/tools/generator/BEP032Templater.py#L94 and https://github.com/INT-NIT/BEP032tools/blob/c135011556278f5e449491f4fe4333f4c3a2a74d/ando/tools/generator/BEP032Templater.py#L68)

We need unittests covering these utility functions.

JuliaSprenger commented 2 years ago

compare also #94