First fix to issue - Githubissues

INT-NIT / BEP032tools

Software tools supporting the BIDS Extension Proposal (BEP) dedicated to adding support for electrophysiological data recorded in animal models (BEP032)

MIT License

3 stars 8 forks source link

First fix to issue #11

Closed Slowblitz closed 4 years ago

Slowblitz commented 4 years ago

Only work in non-verbose mode , adding 1 dataset too

Slowblitz commented 4 years ago

little issue with the source folder is not checked

SylvainTakerkart commented 4 years ago

also, in the checker/tests/test_isAnDO.py file, all the functions are called test_bids_dataset_X... can you replace bids by ando? (and make another search for bids everywhere in the code?)

SylvainTakerkart commented 4 years ago

can you go back to some of the comments on the general page of the PR? (some of them above have not been fixed I think!) https://github.com/INT-NIT/AnDOChecker/pull/11

Slowblitz commented 4 years ago

Like this : ?

SylvainTakerkart commented 4 years ago

yes, perfect ;)

SylvainTakerkart commented 4 years ago

also, on line: https://github.com/INT-NIT/AnDOChecker/blob/d504247e1c99e00389d0e256a7c77bc5d661f2b7/checker/AnDO_Error.py#L14

add a space after the '-' at the beginning of the line, so that you get '- Does'...

and same thing for the other errors...

SylvainTakerkart commented 4 years ago

also, this is still in French: https://github.com/INT-NIT/AnDOChecker/pull/11#discussion_r417960347

Slowblitz commented 4 years ago

French comment is already removed in my file .

SylvainTakerkart commented 4 years ago

French comment is already removed in my file .

oops, sorry! (I'm starting to get confused between all the comments / reviews / commits etc ;) )

SylvainTakerkart commented 4 years ago

LGTM!!! ;)

SylvainTakerkart commented 4 years ago

merging...