Open Remi-Gau opened 2 years ago
Hello @Remi-Gau! Thanks for updating this PR.
ando/tools/generator/tests/test_bidsname.py
:* In the file [`ando/tools/generator/tests/test_bidsname.py`](https://github.com/INT-NIT/BEP032tools/blob/55ff7c8daa1d76c3d7cf706bdc90e3ca1b49a686/ando/tools/generator/tests/test_bidsname.py):
How strict are you on code linting? I am using black and pre-commit to take care of that and it might not agree with pep8speaks.
Might be worth dropping pandas in the setup.py
as it is a pybids dependency anyway.
Totals | |
---|---|
Change from base Build 3203652442: | 0.0% |
Covered Lines: | 1057 |
Relevant Lines: | 1408 |
STATUS
This is WIP and not urgent.
Pybids mostly shines for its ability to query datasets which is not the most needed feature for now.
But if pybids gets updated to query ephys dataset (after the BEP is merged) it may make sense to then only rely on pybids for filenaming.
FYI: