INT-NIT / BEP032tools

Software tools supporting the BIDS Extension Proposal (BEP) dedicated to adding support for electrophysiological data recorded in animal models (BEP032)
MIT License
3 stars 9 forks source link

[ENH] use pybids for filename creation #116

Open Remi-Gau opened 2 years ago

Remi-Gau commented 2 years ago

STATUS

This is WIP and not urgent.

Pybids mostly shines for its ability to query datasets which is not the most needed feature for now.

But if pybids gets updated to query ephys dataset (after the BEP is merged) it may make sense to then only rely on pybids for filenaming.


FYI:

pep8speaks commented 2 years ago

Hello @Remi-Gau! Thanks for updating this PR.

Line 36:9: W503 line break before binary operator

Comment last updated at 2022-05-06 15:09:46 UTC
Remi-Gau commented 2 years ago
* In the file [`ando/tools/generator/tests/test_bidsname.py`](https://github.com/INT-NIT/BEP032tools/blob/55ff7c8daa1d76c3d7cf706bdc90e3ca1b49a686/ando/tools/generator/tests/test_bidsname.py):

Line 36:9: W503 line break before binary operator

How strict are you on code linting? I am using black and pre-commit to take care of that and it might not agree with pep8speaks.

Remi-Gau commented 2 years ago

Might be worth dropping pandas in the setup.py as it is a pybids dependency anyway.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 3429508594


Totals Coverage Status
Change from base Build 3203652442: 0.0%
Covered Lines: 1057
Relevant Lines: 1408

💛 - Coveralls