Closed JuliaSprenger closed 2 years ago
@killianrochet So you tested the instructions in the Readme step-by-step on your machine? From installation to checking the availability of the CLI and the python code snippets?
Hi ! @JuliaSprenger , for the use of the BEP032Generator function when I pass it my data folder as a parameter, the function recreates a data folder in the one that already exists. On the other hand if I don't have a data folder the function stops and gives me an error.
Hi @killianrochet That's a good catch and sounds like we should fix it. Since it's not related directly to the structural changes here, could you open a separate issue and try to address this in another PR? For the PR i would propose to start adding a test first that defines the expected behavior and then implement the fix.
Pull Request Test Coverage Report for Build 1860706642
💛 - Coveralls