search

INT-NIT / BEP032tools

Software tools supporting the BIDS Extension Proposal (BEP) dedicated to adding support for electrophysiological data recorded in animal models (BEP032)
MIT License
3 stars 9 forks source link

Add test for folder generation #124

Closed killianrochet closed 2 years ago

pep8speaks commented 2 years ago

Hello @killianrochet! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2022-04-27 10:49:10 UTC
coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2232562809

Totals Coverage Status
Change from base Build 2089602935: 0.5%
Covered Lines: 896
Relevant Lines: 1239
💛 - Coveralls
JuliaSprenger commented 2 years ago

The next step is that in each of your test functions you create the situation in which the bug occurred. For this it would help to put a description of this in the docstring. Roughly like Ensure that in situation A behavior B does not happen.

JuliaSprenger commented 2 years ago

@killianrochet Last thing to fix: PEP8 (see pep8speaks comment above)

JuliaSprenger commented 2 years ago

@killianrochet And you can mark the PR as ready for review. It's about time ;)

JuliaSprenger commented 2 years ago

Cool :) Thanks for completing this! I will merge it now. :champagne: