Closed SylvainTakerkart closed 1 year ago
OK, I've looked around, it seems ok to me! There will be other things that will need to evolve (the docstring for the BEP032Data class, the list of ESSENTIAL_CSV_COLUMNS), but I don't want to touch them yet... So this PR remains very small and symbolic!
[...] There will be other things that will need to evolve (the docstring for the BEP032Data class, the list of ESSENTIAL_CSV_COLUMNS), but I don't want to touch them yet... You mean the
data_file
in the optional csv colums here? https://github.com/INT-NIT/BEP032tools/blob/be66d25b583d01bf8b1b692c00e82f8389b5dba5/bep032tools/generator/BEP032Generator.py#L33 I think we should for consistency get rid of alldata_file
references that are outdated at the same time....
And since we are on it, maybe also register_data_files
should rather be called register_data_sources
? What do you think?
thanks! I caught a few other spots that needed to be corrected...
WDYT?
This corresponds to some of what we discussed and decided:
generate_bids_dataset
: rename data_file -> data_source, check for consistencysession
, usedata_instance
/ephys_instance
or similar insteadNot yet ready for review, coz I need to check for consistency, ahah ;)