INT-NIT / BEP032tools

Software tools supporting the BIDS Extension Proposal (BEP) dedicated to adding support for electrophysiological data recorded in animal models (BEP032)
MIT License
3 stars 9 forks source link

Adding a BIDSification pipeline for an existing patchclamp data set #140

Open SylvainTakerkart opened 1 year ago

SylvainTakerkart commented 1 year ago

This is NOT ready for review! The code is in the state discussed yesterday... I will document it more when I come back from vacation...

But, here is what we decided with @JuliaSprenger yesterday... The current implementation cannot work. What's to be done is:

  1. in the generate_csv_file function, add one column in the csv file, giving the filename (or file directory) where the excel file is

  2. move the read_xls_file so that it is called in the generate_all_metadata function of this specific class (where the instance exists)

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3641385967


Changes Missing Coverage Covered Lines Changed/Added Lines %
bep032tools/generator/BEP032NWDataConverter.py 0 180 0.0%
<!-- Total: 3 183 1.64% -->
Totals Coverage Status
Change from base Build 3641356290: -8.2%
Covered Lines: 1135
Relevant Lines: 1663

💛 - Coveralls
JuliaSprenger commented 1 year ago

@SylvainTakerkart I fixed some error in the CI in master. You might need to merge the new master version here so the tests are passing also in this branch.

JuliaSprenger commented 1 year ago

Hi @SylvainTakerkart I fixed a the np.isnan bug in master and merged master into your feature branch here. Can you pull again to work on the latest version also locally?