Open SylvainTakerkart opened 1 year ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
bep032tools/generator/BEP032NWDataConverter.py | 0 | 180 | 0.0% | ||
<!-- | Total: | 3 | 183 | 1.64% | --> |
Totals | |
---|---|
Change from base Build 3641356290: | -8.2% |
Covered Lines: | 1135 |
Relevant Lines: | 1663 |
@SylvainTakerkart I fixed some error in the CI in master. You might need to merge the new master version here so the tests are passing also in this branch.
Hi @SylvainTakerkart I fixed a the np.isnan
bug in master and merged master into your feature branch here. Can you pull again to work on the latest version also locally?
This is NOT ready for review! The code is in the state discussed yesterday... I will document it more when I come back from vacation...
But, here is what we decided with @JuliaSprenger yesterday... The current implementation cannot work. What's to be done is:
in the generate_csv_file function, add one column in the csv file, giving the filename (or file directory) where the excel file is
move the read_xls_file so that it is called in the generate_all_metadata function of this specific class (where the instance exists)