Open SylvainTakerkart opened 3 months ago
Hello @sifaoufatai ,
I agree with all your comments, and I just want to add something that's very important in my opinion:
What I mean is that you don't have to use / test the functions in the main files, you have to test / use them in the test_files which are provided for that purpose. Later on you'll start doing unit tests, so I think it's a good idea to start adopting this separation to simplify your life in the future.
Hello @sifaoufatai ,
Before implementing new functionnalities, I think it would be good to clean up the current version of your code and do some refactoring...
the
bep32v01
directory needs to be renamed because:about
launch.py
config_path
andoutput_path
: one is a file, the other one is a directory, so they should not be called with similar names (with bothpath
)... to make the difference between files and directories, you can look at other big open source projects and see how they call files and directories (for ex. scikit learn)json_path = config_path
oroutput = output_path
should not exist!: use only one variable name, a meaningful one ;)@killianrochet can check on all these details if I'm not available tomorrow!