Open sifaoufatai opened 2 months ago
Second comment (from a pure "user" point of view): I simply tried to run python ./writing_agnosticfile.py
. It runs, it does not give me any error message... As we discussed, this should not be executable!
Third comment: there should be a cleaning step at the end (removing temporary files like; because if these are not removed, the data set will not be validated )...
Fourth comment: I think only "required files" should be created (as we discussed some time ago) in the general cases. Then, "recommended" and "optional" files are created only if metadata is found to go in these files...
Hello @sifaoufatai! Thanks for updating this PR.
BIDSTools/ProcessBIDSDATA.py
:Line 510:101: E501 line too long (102 > 100 characters)
BIDSTools/try.py
:Line 167:1: E303 too many blank lines (5)
Thanks for the PR @sifaoufatai !
First comment: there should be a description, instead of having "No description provided", so that the reviewer of the PR can understand the goals (and therefore do the review accordingly)...