BIDSfication Algorithm Update with New Metadata Formula

INT-NIT / BEP032tools

Software tools supporting the BIDS Extension Proposal (BEP) dedicated to adding support for electrophysiological data recorded in animal models (BEP032)

MIT License

3 stars 9 forks source link

BIDSfication Algorithm Update with New Metadata Formula #154

Open sifaoufatai opened 2 months ago

SylvainTakerkart commented 2 months ago

No description provided.

Thanks for the PR @sifaoufatai !

First comment: there should be a description, instead of having "No description provided", so that the reviewer of the PR can understand the goals (and therefore do the review accordingly)...

SylvainTakerkart commented 2 months ago

Second comment (from a pure "user" point of view): I simply tried to run python ./writing_agnosticfile.py. It runs, it does not give me any error message... As we discussed, this should not be executable!

SylvainTakerkart commented 2 months ago

Third comment: there should be a cleaning step at the end (removing temporary files like; because if these are not removed, the data set will not be validated )...

SylvainTakerkart commented 2 months ago

Fourth comment: I think only "required files" should be created (as we discussed some time ago) in the general cases. Then, "recommended" and "optional" files are created only if metadata is found to go in these files...

pep8speaks commented 1 month ago

Hello @sifaoufatai! Thanks for updating this PR.

In the file BIDSTools/ProcessBIDSDATA.py:

Line 510:101: E501 line too long (102 > 100 characters)

In the file BIDSTools/try.py:

Line 167:1: E303 too many blank lines (5)

INT-NIT / BEP032tools

BIDSfication Algorithm Update with New Metadata Formula #154

Comment last updated at 2024-09-04 12:30:44 UTC